Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 41503004: - Account for hidden frames when concatenating throw and (Closed)

Created:
7 years, 2 months ago by Ivan Posva
Modified:
7 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Account for hidden frames when concatenating throw and catch traces. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=29218

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M runtime/tests/vm/vm.status View 1 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 4 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
7 years, 2 months ago (2013-10-24 21:37:29 UTC) #1
siva
lgtm
7 years, 2 months ago (2013-10-24 21:40:12 UTC) #2
Ivan Posva
7 years, 2 months ago (2013-10-24 22:08:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29218 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698