New 'use similar' fixes.

New 'use similar' fixes.

R=paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=38580

[Paul Berry, 2014-07-25 18:10:37]

lgtm

https://codereview.chromium.org/414273002/diff/1/pkg/analysis_services/lib/sr...
File pkg/analysis_services/lib/src/correction/fix.dart (right):

https://codereview.chromium.org/414273002/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/correction/fix.dart:1104: void
_addFix_undefinedFunction_useSimilar() {
Any way we could share code between this function and
_addFix_undefinedClass_useSimilar()?  They look almost the same.

https://codereview.chromium.org/414273002/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/correction/fix.dart:1932: int memberDistance =
getLevenshteinDistance(element.name, _targetName);
Levenshtein distance is O(n*m) to compute in the worst case.  Would it be worth
making either of the following optimizations?

1. Pass _distance into getLevenshteinDistance().  If it determines that the edit
distance would be greater than _distance, it can bail out early.

2. Since the users of this class will reject any elements whose distance >= 5,
initialize _distance to 5 (or to a value supplied by the caller); that way we
don't waste time computing edit distances for strings that we would never
possibly use.  (Note: only useful if we also do 1).

[scheglov, 2014-07-25 18:17:43]

Committed patchset #1 manually as r38580 (presubmit successful).

[scheglov, 2014-07-25 18:53:29]

https://codereview.chromium.org/414273002/diff/1/pkg/analysis_services/lib/sr...
File pkg/analysis_services/lib/src/correction/fix.dart (right):

https://codereview.chromium.org/414273002/diff/1/pkg/analysis_services/lib/sr...
pkg/analysis_services/lib/src/correction/fix.dart:1932: int memberDistance =
getLevenshteinDistance(element.name, _targetName);
On 2014/07/25 18:10:36, Paul Berry wrote:
> Levenshtein distance is O(n*m) to compute in the worst case.  Would it be
worth
> making either of the following optimizations?
> 
> 1. Pass _distance into getLevenshteinDistance().  If it determines that the
edit
> distance would be greater than _distance, it can bail out early.
> 
> 2. Since the users of this class will reject any elements whose distance >= 5,
> initialize _distance to 5 (or to a value supplied by the caller); that way we
> don't waste time computing edit distances for strings that we would never
> possibly use.  (Note: only useful if we also do 1).

https://codereview.chromium.org/417263003