Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 414193002: Add parseJson to DartUtilities. (Closed)

Created:
6 years, 5 months ago by rmacnak
Modified:
6 years, 4 months ago
Reviewers:
vsm, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add parseJson to DartUtilities and mark xhr_test/json as passing. BUG=http://dartbug.com/13069 R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=39158

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/src/html_native_DOMImplementation.dart View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmacnak
6 years, 4 months ago (2014-08-02 00:02:16 UTC) #1
blois
https://codereview.chromium.org/414193002/diff/20001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (right): https://codereview.chromium.org/414193002/diff/20001/sdk/lib/html/dartium/html_dartium.dart#newcode37534 sdk/lib/html/dartium/html_dartium.dart:37534: + static parseJson(String jsonSource) => const JsonDecoder().convert(jsonSource); Should this ...
6 years, 4 months ago (2014-08-02 00:16:30 UTC) #2
vsm
https://chromiumcodereview.appspot.com/414193002/diff/20001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (right): https://chromiumcodereview.appspot.com/414193002/diff/20001/sdk/lib/html/dartium/html_dartium.dart#newcode37534 sdk/lib/html/dartium/html_dartium.dart:37534: + static parseJson(String jsonSource) => const JsonDecoder().convert(jsonSource); On 2014/08/02 ...
6 years, 4 months ago (2014-08-04 14:34:42 UTC) #3
rmacnak
Made the change in html_native_DOMImplementation.dart and ran dom/scripts/go.sh
6 years, 4 months ago (2014-08-06 17:59:34 UTC) #4
vsm
lgtm
6 years, 4 months ago (2014-08-12 08:19:55 UTC) #5
rmacnak
6 years, 4 months ago (2014-08-12 18:44:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as 39158 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698