Issue 414183004: Fix template binding. Turns out that bindCallback by default traps excepions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 414183004: Fix template binding. Turns out that bindCallback by default traps excepions (Closed)

Created:
6 years, 4 months ago by Siggi Cherem (dart-lang)

Modified:
6 years, 4 months ago

Reviewers:
jakemac

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix template binding. Turns out that bindCallback by default traps excepions too, and throws them asynchronously. Our APIs expected those exceptions to be thrown synchronously. Committed: https://code.google.com/p/dart/source/detail?r=38761

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	pkg/template_binding/CHANGELOG.md	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/template_binding/lib/src/node.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/template_binding/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

Committed patchset #1 manually as r38761 (presubmit successful).

6 years, 4 months ago (2014-07-30 23:05:35 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages