Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 414093003: Make deferred loading of message libraries optional (Closed)

Created:
6 years, 5 months ago by Alan Knight
Modified:
6 years, 5 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make deferred loading of message libraries optional BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=38553

Patch Set 1 #

Patch Set 2 : Add a new file I had missed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -8 lines) Patch
M pkg/intl/CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/intl/bin/generate_from_arb.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/intl/lib/generate_localized.dart View 2 chunks +12 lines, -2 lines 0 comments Download
M pkg/intl/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A pkg/intl/test/message_extraction/message_extraction_no_deferred_test.dart View 1 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/intl/test/message_extraction/message_extraction_test.dart View 2 chunks +10 lines, -3 lines 0 comments Download
M pkg/intl/test/message_extraction/sample_with_messages.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
6 years, 5 months ago (2014-07-24 20:26:16 UTC) #1
Emily Fortuna
lgtm
6 years, 5 months ago (2014-07-24 20:45:12 UTC) #2
Alan Knight
6 years, 5 months ago (2014-07-24 21:16:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r38553 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698