Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 41383002: fix binding to $ from polymer templates (Closed)

Created:
7 years, 2 months ago by Jennifer Messerly
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix binding to $ from polymer templates https://code.google.com/p/dart/issues/detail?id=14172 there were two issues: * "$" needs to be reflectable * the Map needs to be observable so templates can detect when keys get added (happens after template instantiation) R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=29208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M pkg/polymer/lib/src/instance.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/polymer/test/bind_test.dart View 2 chunks +16 lines, -6 lines 0 comments Download
M pkg/polymer/test/bind_test.html View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
7 years, 2 months ago (2013-10-24 20:43:19 UTC) #1
Siggi Cherem (dart-lang)
lgtm!
7 years, 2 months ago (2013-10-24 20:58:05 UTC) #2
Jennifer Messerly
7 years, 2 months ago (2013-10-24 21:15:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29208 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698