Issue 413723002: - Fix build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 413723002: - Fix build. (Closed)

Created:
6 years, 5 months ago by Ivan Posva

Modified:
6 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Fix build. Committed: https://code.google.com/p/dart/source/detail?r=38503

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	runtime/vm/object_test.cc	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Committed patchset #1 manually as r38503 (presubmit successful).

6 years, 5 months ago (2014-07-23 14:43:42 UTC) #2

siva

6 years, 5 months ago (2014-07-23 16:44:49 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/413723002/diff/1/runtime/vm/object_test.cc
File runtime/vm/object_test.cc (right):

https://codereview.chromium.org/413723002/diff/1/runtime/vm/object_test.cc#ne...
runtime/vm/object_test.cc:321: EXPECT(Smi::IsValid(-1));
Why did you get rid of this test?

Expand Messages | Collapse Messages