Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 413403002: Fix lingering references to the old Span in yaml. (Closed)

Created:
6 years, 5 months ago by nweiz
Modified:
6 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix lingering references to the old Span in yaml. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M pkg/yaml/CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/yaml/lib/src/null_span.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/yaml/lib/src/yaml_node.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/yaml/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/yaml/test/yaml_node_wrapper_test.dart View 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 5 months ago (2014-07-25 01:29:38 UTC) #1
Bob Nystrom
lgtm
6 years, 5 months ago (2014-07-25 21:10:38 UTC) #2
nweiz
6 years, 4 months ago (2014-07-29 01:37:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38656 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698