Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 413193002: pkg/logging: use UnmodifiableMapView from dart:collection (Closed)

Created:
6 years, 5 months ago by kevmoo
Modified:
6 years, 5 months ago
Reviewers:
sethladd
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/logging: use UnmodifiableMapView from dart:collection remove documentation URL remove (now) unused collection pkg import move intro docs to README.md R=sethladd@google.com Committed: https://code.google.com/p/dart/source/detail?r=38546

Patch Set 1 #

Total comments: 4

Patch Set 2 : removed initial line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -52 lines) Patch
A pkg/logging/README.md View 1 1 chunk +42 lines, -0 lines 0 comments Download
M pkg/logging/lib/logging.dart View 1 chunk +1 line, -45 lines 0 comments Download
M pkg/logging/pubspec.yaml View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo
6 years, 5 months ago (2014-07-24 16:26:44 UTC) #1
sethladd
lgtm with some suggestions https://codereview.chromium.org/413193002/diff/1/pkg/logging/README.md File pkg/logging/README.md (right): https://codereview.chromium.org/413193002/diff/1/pkg/logging/README.md#newcode1 pkg/logging/README.md:1: Support for logging. Nit: start ...
6 years, 5 months ago (2014-07-24 16:48:13 UTC) #2
kevmoo
https://codereview.chromium.org/413193002/diff/1/pkg/logging/README.md File pkg/logging/README.md (right): https://codereview.chromium.org/413193002/diff/1/pkg/logging/README.md#newcode1 pkg/logging/README.md:1: Support for logging. On 2014/07/24 16:48:13, sethladd wrote: > ...
6 years, 5 months ago (2014-07-24 17:44:18 UTC) #3
kevmoo
6 years, 5 months ago (2014-07-24 17:44:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r38546 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698