Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 41293002: Fixes from polymer.dart API review (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixes from polymer.dart API review Primary breaking changes are: - polymer/platform.dart is removed - Rather than platform.flush, use scheduleMicrotask(Observable.dirtyCheck) - Rather than endOfMicrotask, use either scheduleMicrotask or Future.value - Polymer.job removed, use Timer instead (and upvote bug 14414 for timer.restart if you really want the job semantics) This change is bringing up some really weird timing issues in the tests- I don't think any are inherent to the change itself but is more indicative of larger issues. BUG=13666 R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=29311

Patch Set 1 : #

Patch Set 2 : Made Job a part of polymer #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -152 lines) Patch
M pkg/polymer/lib/deserialize.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D pkg/polymer/lib/job.dart View 1 1 chunk +0 lines, -54 lines 0 comments Download
M pkg/polymer/lib/platform.dart View 1 chunk +0 lines, -40 lines 0 comments Download
M pkg/polymer/lib/polymer.dart View 1 2 chunks +1 line, -2 lines 0 comments Download
M pkg/polymer/lib/src/instance.dart View 1 5 chunks +4 lines, -15 lines 0 comments Download
A + pkg/polymer/lib/src/job.dart View 1 2 chunks +6 lines, -10 lines 0 comments Download
M pkg/polymer/test/bind_mdv_test.dart View 3 chunks +4 lines, -6 lines 0 comments Download
M pkg/polymer/test/prop_attr_reflection_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/polymer/test/template_distribute_dynamic_test.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M pkg/polymer/test/unbind_test.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M samples/third_party/todomvc/test/listorder_test.dart View 3 chunks +10 lines, -9 lines 1 comment Download
M samples/third_party/todomvc/test/markdone_test.dart View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
blois
7 years, 1 month ago (2013-10-25 18:17:27 UTC) #1
Jennifer Messerly
regarding polymer/lib/job.dart -- it's technically public. Consider at least making "Job" type internal? Or have ...
7 years, 1 month ago (2013-10-25 19:24:39 UTC) #2
Jennifer Messerly
regarding tests: are they flaky now? Or do they work with your changes? code changes ...
7 years, 1 month ago (2013-10-25 19:25:14 UTC) #3
blois
On 2013/10/25 19:25:14, John Messerly wrote: > regarding tests: are they flaky now? Or do ...
7 years, 1 month ago (2013-10-25 20:52:11 UTC) #4
Jennifer Messerly
https://codereview.chromium.org/41293002/diff/160001/samples/third_party/todomvc/test/listorder_test.dart File samples/third_party/todomvc/test/listorder_test.dart (right): https://codereview.chromium.org/41293002/diff/160001/samples/third_party/todomvc/test/listorder_test.dart#newcode36 samples/third_party/todomvc/test/listorder_test.dart:36: return window.animationFrame.then((_) { one idea here is to use ...
7 years, 1 month ago (2013-10-25 21:02:21 UTC) #5
blois
7 years, 1 month ago (2013-10-26 16:33:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r29311 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698