|
|
Fixes from polymer.dart API review
Primary breaking changes are:
- polymer/platform.dart is removed
- Rather than platform.flush, use scheduleMicrotask(Observable.dirtyCheck)
- Rather than endOfMicrotask, use either scheduleMicrotask or Future.value
- Polymer.job removed, use Timer instead (and upvote bug 14414 for timer.restart if you really want the job semantics)
This change is bringing up some really weird timing issues in the tests- I don't think any are inherent to the change itself but is more indicative of larger issues.
BUG= 13666
R=jmesserly@google.com
Committed: https://code.google.com/p/dart/source/detail?r=29311
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+35 lines, -152 lines) |
Patch |
 |
M |
pkg/polymer/lib/deserialize.dart
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
D |
pkg/polymer/lib/job.dart
|
View
|
1
|
1 chunk |
+0 lines, -54 lines |
0 comments
|
Download
|
 |
M |
pkg/polymer/lib/platform.dart
|
View
|
|
1 chunk |
+0 lines, -40 lines |
0 comments
|
Download
|
 |
M |
pkg/polymer/lib/polymer.dart
|
View
|
1
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/polymer/lib/src/instance.dart
|
View
|
1
|
5 chunks |
+4 lines, -15 lines |
0 comments
|
Download
|
 |
A + |
pkg/polymer/lib/src/job.dart
|
View
|
1
|
2 chunks |
+6 lines, -10 lines |
0 comments
|
Download
|
 |
M |
pkg/polymer/test/bind_mdv_test.dart
|
View
|
|
3 chunks |
+4 lines, -6 lines |
0 comments
|
Download
|
 |
M |
pkg/polymer/test/prop_attr_reflection_test.dart
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
pkg/polymer/test/template_distribute_dynamic_test.dart
|
View
|
|
3 chunks |
+2 lines, -5 lines |
0 comments
|
Download
|
 |
M |
pkg/polymer/test/unbind_test.dart
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
samples/third_party/todomvc/test/listorder_test.dart
|
View
|
|
3 chunks |
+10 lines, -9 lines |
1 comment
|
Download
|
 |
M |
samples/third_party/todomvc/test/markdone_test.dart
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
Total messages: 6 (0 generated)
|