Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 41273002: VM and dart2js both support ne mixin syntax. (Closed)

Created:
7 years, 1 month ago by scheglov
Modified:
7 years, 1 month ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

VM and dart2js both support ne mixin syntax. https://code.google.com/p/dart/issues/detail?id=13907 It seems that packages and other code were migrate too. So, we can turn on error for the old syntax. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29211

Patch Set 1 #

Patch Set 2 : Try to upload. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java View 1 chunk +2 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java View 2 chunks +12 lines, -14 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 1 month ago (2013-10-24 19:56:01 UTC) #1
Brian Wilkerson
LGTM
7 years, 1 month ago (2013-10-24 20:24:23 UTC) #2
scheglov
7 years, 1 month ago (2013-10-24 21:42:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29211 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698