Issue 412393002: Skip the pool tests on the Dartium bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 412393002: Skip the pool tests on the Dartium bots. (Closed)

Created:
6 years, 5 months ago by nweiz

Modified:
6 years, 5 months ago

Reviewers:
Emily Fortuna, kustermann

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Skip the pool tests on the Dartium bots. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=38557

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	pkg/pkg.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

nweiz

Committed patchset #1 manually as r38557 (presubmit successful).

6 years, 5 months ago (2014-07-24 21:48:47 UTC) #3

kustermann

If a change of yours caused a failure, it is better to revert your change ...

6 years, 5 months ago (2014-07-24 22:55:42 UTC) #4

nweiz

6 years, 5 months ago (2014-07-24 23:02:05 UTC) #5

Message was sent while issue was closed.

On 2014/07/24 22:55:42, kustermann wrote:
> If a change of yours caused a failure, it is better to revert your change
> instead of adding Skip markers.

I disagree. The failure is caused by the referenced bug in the Dartium bots'
build process; it doesn't make sense to block my change on that bug being fixed,
especially since Rico is on vacation.

Expand Messages | Collapse Messages