Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 412323002: Start writing analysis server integration test for 'completion.getSuggestions'. (Closed)

Created:
6 years, 5 months ago by Paul Berry
Modified:
6 years, 5 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org, danrubel
Visibility:
Public.

Description

Start writing analysis server integration test for 'completion.getSuggestions'. The test is currently incomplete (and hence disabled) due to dartbug.com/20188. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=38559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
A pkg/analysis_server/test/integration/completion_domain_inttest.dart View 1 chunk +51 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 5 months ago (2014-07-24 20:12:18 UTC) #1
jwren
LGTM
6 years, 5 months ago (2014-07-24 20:18:34 UTC) #2
Paul Berry
6 years, 5 months ago (2014-07-24 22:08:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38559 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698