Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 411953003: Disable tests which require cross frame access (same origin) (Closed)

Created:
6 years, 5 months ago by Leaf
Modified:
6 years, 5 months ago
Reviewers:
vsm, Jacob
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Disable tests which require cross frame access (same origin) Several co19 tests assume that the result of window.open will be a window (instead of a cross frame window), and try to perform illegal operations on it. These are already disabled for dart2js. For dartium, these were (incorrectly) working because of https://code.google.com/p/dart/issues/detail?id=20143 . This CL disables these tests for Dartium. Depending on the resolution of https://code.google.com/p/dart/issues/detail?id=20146 , they may later be enabled. BUG=https://code.google.com/p/dart/issues/detail?id=20143 R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=38542

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tests/co19/co19-dartium.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Leaf
6 years, 5 months ago (2014-07-23 18:21:16 UTC) #1
Leaf
6 years, 5 months ago (2014-07-24 16:46:04 UTC) #2
Jacob
lgtm
6 years, 5 months ago (2014-07-24 16:47:43 UTC) #3
Leaf
6 years, 5 months ago (2014-07-24 17:08:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r38542 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698