Issue 41163005: Add JsArray

Issue 41163005: Add JsArray (Closed)

Created:
7 years, 2 months ago by justinfagnani

Modified:
7 years, 1 month ago

Reviewers:
ngeoffray, Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add JsArray BUG= R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=29393

Patch Set 2 : rebased and addressed review comments #

Patch Set 5 : landing jsarray #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+384 lines, -26 lines)			Patch
M	sdk/lib/js/dart2js/js_dart2js.dart	View	1 2	12 chunks	+129 lines, -15 lines	0 comments	Download
M	sdk/lib/js/dartium/js_dartium.dart	View	1 2 3 4	2 chunks	+92 lines, -0 lines	0 comments	Download
M	tests/html/js_test.dart	View	1 2 3	6 chunks	+161 lines, -11 lines	1 comment	Download
M	tools/dom/scripts/systemnative.py	View	1 2 3 4	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Jacob

lgtm https://codereview.chromium.org/41163005/diff/50001/sdk/lib/js/dart2js/js_dart2js.dart File sdk/lib/js/dart2js/js_dart2js.dart (right): https://codereview.chromium.org/41163005/diff/50001/sdk/lib/js/dart2js/js_dart2js.dart#newcode225 sdk/lib/js/dart2js/js_dart2js.dart:225: _checkIndex(int index, {bool insert: false}) { why not ...

7 years, 2 months ago (2013-10-24 21:02:08 UTC) #2

justinfagnani

https://codereview.chromium.org/41163005/diff/50001/sdk/lib/js/dart2js/js_dart2js.dart File sdk/lib/js/dart2js/js_dart2js.dart (right): https://codereview.chromium.org/41163005/diff/50001/sdk/lib/js/dart2js/js_dart2js.dart#newcode225 sdk/lib/js/dart2js/js_dart2js.dart:225: _checkIndex(int index, {bool insert: false}) { On 2013/10/24 21:02:09, ...

7 years, 1 month ago (2013-10-26 03:26:51 UTC) #3

Jacob

On 2013/10/28 20:13:03, justinfagnani wrote: > remove JS type check for DartObject in tests lgtm

7 years, 1 month ago (2013-10-28 20:41:36 UTC) #6

Jacob

Committed patchset #5 manually as r29393 (presubmit successful).

7 years, 1 month ago (2013-10-28 20:46:46 UTC) #7

ngeoffray

7 years, 1 month ago (2013-10-29 11:44:19 UTC) #8

Message was sent while issue was closed.

https://codereview.chromium.org/41163005/diff/210001/tests/html/js_test.dart
File tests/html/js_test.dart (right):

https://codereview.chromium.org/41163005/diff/210001/tests/html/js_test.dart#...
tests/html/js_test.dart:322: expect(a['length'], 0);
How is that supposed to work? JsArray[] is typed as taking an int, so in checked
mode, there will be a TypeError.

I have filed https://code.google.com/p/dart/issues/detail?id=14571.

Expand Messages | Collapse Messages