Issue 411263006: Add timeout tests for the pool package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 411263006: Add timeout tests for the pool package. (Closed)

Created:
6 years, 5 months ago by nweiz

Modified:
6 years, 5 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org, Bob Nystrom

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add timeout tests for the pool package. R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=38552

Patch Set 2 : Code review changes #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+133 lines, -72 lines)			Patch
A	pkg/pool/CHANGELOG.md	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/pool/lib/pool.dart	View	1	2 chunks	+8 lines, -5 lines	0 comments	Download
M	pkg/pool/pubspec.yaml	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/pool/test/pool_test.dart	View		4 chunks	+120 lines, -66 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

lgtm https://codereview.chromium.org/411263006/diff/1/pkg/pool/lib/pool.dart File pkg/pool/lib/pool.dart (right): https://codereview.chromium.org/411263006/diff/1/pkg/pool/lib/pool.dart#newcode50 pkg/pool/lib/pool.dart:50: /// indented to avoid deadlocks. should be "intended"?

6 years, 5 months ago (2014-07-24 20:28:15 UTC) #2

nweiz

https://codereview.chromium.org/411263006/diff/1/pkg/pool/lib/pool.dart File pkg/pool/lib/pool.dart (right): https://codereview.chromium.org/411263006/diff/1/pkg/pool/lib/pool.dart#newcode50 pkg/pool/lib/pool.dart:50: /// indented to avoid deadlocks. On 2014/07/24 20:28:15, Alan ...

6 years, 5 months ago (2014-07-24 20:29:21 UTC) #4

nweiz

6 years, 5 months ago (2014-07-24 20:29:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r38552 (presubmit successful).

Expand Messages | Collapse Messages

Issue 411263006: Add timeout tests for the pool package. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Code review changes #

Messages