Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1813)

Issue 411203002: Swallow errors in subscriptions in http_multi_server.. (Closed)

Created:
6 years, 5 months ago by nweiz
Modified:
6 years, 5 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Swallow errors in subscriptions in http_multi_server.. BUG=19815 R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=38532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -34 lines) Patch
A pkg/http_multi_server/CHANGELOG.md View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/http_multi_server/lib/http_multi_server.dart View 1 chunk +6 lines, -11 lines 0 comments Download
M pkg/http_multi_server/lib/src/utils.dart View 3 chunks +13 lines, -21 lines 0 comments Download
M pkg/http_multi_server/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http_multi_server/test/http_multi_server_test.dart View 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 5 months ago (2014-07-24 00:41:53 UTC) #1
Alan Knight
lgtm
6 years, 5 months ago (2014-07-24 00:47:32 UTC) #2
nweiz
6 years, 5 months ago (2014-07-24 01:42:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38532 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698