Issue 41113002: Properly report error for certain expressions that must be const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 41113002: Properly report error for certain expressions that must be const (Closed)

Created:
7 years, 2 months ago by hausner

Modified:
7 years, 2 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Properly report error for certain expressions that must be const Issue error message instead of hitting assertion for an expression that contains an assignment but is expected to be const. Fixes security issue 13941 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=29194

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	runtime/vm/parser.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

7 years, 2 months ago (2013-10-24 18:54:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29194 (presubmit successful).

Expand Messages | Collapse Messages