Issue 40983002: Renamed contains in the rectangle class to containsRectangle.

Issue 40983002: Renamed contains in the rectangle class to containsRectangle. (Closed)

Created:
7 years, 1 month ago by Emily Fortuna

Modified:
7 years, 1 month ago

Reviewers:
Lasse Reichstein Nielsen, floitsch, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Renamed contains in the rectangle class to containsRectangle. BUG=https://code.google.com/p/dart/issues/detail?id=13876 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=29203

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -5 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/math/rectangle.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/dom.py	View	1 chunk	+0 lines, -1 line	2 comments	Download
M	tools/dom/templates/html/impl/impl_ClientRect.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

This change cuts off 3k of the added 5k in swarm from moving Rectangle to ...

7 years, 1 month ago (2013-10-24 18:08:39 UTC) #1

floitsch

LGTM with comment. https://codereview.chromium.org/40983002/diff/1/tools/dom/dom.py File tools/dom/dom.py (left): https://codereview.chromium.org/40983002/diff/1/tools/dom/dom.py#oldcode83 tools/dom/dom.py:83: '--disallow-unsafe-eval', unrelated change?

7 years, 1 month ago (2013-10-24 18:27:30 UTC) #2

Emily Fortuna

https://codereview.chromium.org/40983002/diff/1/tools/dom/dom.py File tools/dom/dom.py (left): https://codereview.chromium.org/40983002/diff/1/tools/dom/dom.py#oldcode83 tools/dom/dom.py:83: '--disallow-unsafe-eval', On 2013/10/24 18:27:30, floitsch wrote: > unrelated change? ...

7 years, 1 month ago (2013-10-24 18:28:27 UTC) #3

Emily Fortuna

7 years, 1 month ago (2013-10-24 20:27:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r29203 (presubmit successful).

Expand Messages | Collapse Messages