Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 408663004: Add Dart stack walker (Closed)

Created:
6 years, 5 months ago by Cutch
Modified:
6 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add Dart stack walker that relies on frame pointers. * It is used only when we don't have a top exit frame and we have the script tag set. * Steps across exit frames and only collects Dart frames. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38475

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -23 lines) Patch
M runtime/vm/profiler.h View 2 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/profiler.cc View 1 6 chunks +173 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Cutch
6 years, 5 months ago (2014-07-21 17:54:20 UTC) #1
siva
lgtm https://chromiumcodereview.appspot.com/408663004/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://chromiumcodereview.appspot.com/408663004/diff/1/runtime/vm/profiler.cc#newcode1783 runtime/vm/profiler.cc:1783: } set pc_ only after determining that you ...
6 years, 5 months ago (2014-07-22 20:31:12 UTC) #2
Cutch
https://chromiumcodereview.appspot.com/408663004/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://chromiumcodereview.appspot.com/408663004/diff/1/runtime/vm/profiler.cc#newcode1783 runtime/vm/profiler.cc:1783: } On 2014/07/22 20:31:12, siva wrote: > set pc_ ...
6 years, 5 months ago (2014-07-22 20:50:12 UTC) #3
Cutch
6 years, 5 months ago (2014-07-22 21:08:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r38475 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698