Issue 408143009: pkg/matcher: removed deprecated matchers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 408143009: pkg/matcher: removed deprecated matchers (Closed)

Created:
6 years, 5 months ago by kevmoo

Modified:
6 years, 5 months ago

Reviewers:
sethladd

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/matcher: removed deprecated matchers Updated pubspec to remove documentation URL R=sethladd@google.com Committed: https://code.google.com/p/dart/source/detail?r=38477

Patch Set 2 : updated homepage #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -72 lines)			Patch
M	pkg/matcher/CHANGELOG.md	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/matcher/lib/src/error_matchers.dart	View		2 chunks	+0 lines, -36 lines	0 comments	Download
M	pkg/matcher/pubspec.yaml	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
D	pkg/matcher/test/deprecated_matchers_test.dart	View		1 chunk	+0 lines, -33 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sethladd

lgtm but would love to fix all the homepage links https://codereview.chromium.org/408143009/diff/1/pkg/matcher/pubspec.yaml File pkg/matcher/pubspec.yaml (right): https://codereview.chromium.org/408143009/diff/1/pkg/matcher/pubspec.yaml#newcode5 ...

6 years, 5 months ago (2014-07-22 21:13:03 UTC) #2

kevmoo

https://codereview.chromium.org/408143009/diff/1/pkg/matcher/pubspec.yaml File pkg/matcher/pubspec.yaml (right): https://codereview.chromium.org/408143009/diff/1/pkg/matcher/pubspec.yaml#newcode5 pkg/matcher/pubspec.yaml:5: homepage: http://www.dartlang.org On 2014/07/22 21:13:02, sethladd wrote: > is ...

6 years, 5 months ago (2014-07-22 21:31:13 UTC) #3

kevmoo

6 years, 5 months ago (2014-07-22 21:31:35 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r38477 (presubmit successful).

Expand Messages | Collapse Messages

Issue 408143009: pkg/matcher: removed deprecated matchers (Closed)

Description

Patch Set 1 #

Patch Set 2 : updated homepage #

Messages