Issue 407443002: Fix analysis server 'analysis.getHover' when there is no hover information.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 407443002: Fix analysis server 'analysis.getHover' when there is no hover information. (Closed)

Created:
6 years, 5 months ago by Paul Berry

Modified:
6 years, 5 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix analysis server 'analysis.getHover' when there is no hover information. Previously we returned {'hovers': [null]}. We now return {'hovers': []}. Also, tweak the analysis.getHover unit tests to use futures uniformly rather than a mix of futures and CPS. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38366

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -19 lines)			Patch
M	pkg/analysis_server/lib/src/domain_analysis.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/analysis_hover_test.dart	View	10 chunks	+25 lines, -17 lines	0 comments	Download
M	pkg/analysis_server/test/integration/analysis_domain_inttest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

6 years, 5 months ago (2014-07-18 03:30:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r38366 (presubmit successful).

Expand Messages | Collapse Messages