Implementation of the 'analysis.getErrors' API.

Implementation of the 'analysis.getErrors' API.

R=paulberry@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=38476

[Paul Berry, 2014-07-22 21:10:24]

lgtm

https://codereview.chromium.org/407263002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/407263002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:641: // prepare AnalysisContext
I can see three areas where we might want to improve this function in future
CL's.  Can we add TODO comments for them?

1. The analysis context should be told to analyze this particular file ASAP.

2. We should complete the future as soon as the file is analyzed (not wait until
the context is completely finished)

3. Since contexts can be created and deleted asynchronously as a result of
changes to the filesystem, there's a danger that the future might never get
completed.  We should add a mechanism to make sure that we return an error for
any getErrors request that is unsatisfiable due to its context being deleted.

[scheglov, 2014-07-22 21:23:24]

https://codereview.chromium.org/407263002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/analysis_server.dart (right):

https://codereview.chromium.org/407263002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/analysis_server.dart:641: // prepare AnalysisContext
On 2014/07/22 21:10:24, Paul Berry wrote:
> I can see three areas where we might want to improve this function in future
> CL's.  Can we add TODO comments for them?
> 
> 1. The analysis context should be told to analyze this particular file ASAP.
> 
> 2. We should complete the future as soon as the file is analyzed (not wait
until
> the context is completely finished)

  Unfortunately, there is no mechanism in the analysis engine to guaranty that
the file's analysis is finished.
  It is the same problem IntelliJ plug-in has - we don't want to wait for any
specific phase to be done.
  Hm... Or may be it is OK in the server, because we control both Engine and
Server implementations.

  It's still tricky for HTML files, which may be Angular templates.
  Or with analysis plug-ins in the general case.

  I will add TODO, we can decide later how to solve it.

> 
> 3. Since contexts can be created and deleted asynchronously as a result of
> changes to the filesystem, there's a danger that the future might never get
> completed.  We should add a mechanism to make sure that we return an error for
> any getErrors request that is unsatisfiable due to its context being deleted.

  OK

[scheglov, 2014-07-22 21:24:17]

Committed patchset #1 manually as r38476 (presubmit successful).