Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 407143004: Change the Dart API call Dart_FInalizeLoading to accept an additional argument (Closed)

Created:
6 years, 5 months ago by siva
Modified:
6 years, 5 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Change the Dart API call Dart_FInalizeLoading to accept an additional argument which makes completion of deferred library futures optional. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=38463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M runtime/bin/dartutils.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/include/dart_api.h View 1 chunk +9 lines, -5 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +15 lines, -13 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
6 years, 5 months ago (2014-07-22 16:16:24 UTC) #1
hausner
lgtm
6 years, 5 months ago (2014-07-22 16:39:54 UTC) #2
siva
6 years, 5 months ago (2014-07-22 16:56:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38463 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698