Issue 40703002: Updating MutationObserver.observe documentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40703002: Updating MutationObserver.observe documentation. (Closed)

Created:
7 years, 2 months ago by blois

Modified:
7 years, 2 months ago

Reviewers:
Andrei Mouravski

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Updating MutationObserver.observe documentation. TBR BUG=14375 Committed: https://code.google.com/p/dart/source/detail?r=29181

Patch Set 1 #

Total comments: 5

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -0 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_MutationObserver.darttemplate	View	1 chunk	+10 lines, -0 lines	5 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

blois

Committed patchset #1 manually as r29181 (presubmit successful).

7 years, 2 months ago (2013-10-24 17:01:14 UTC) #1

Andrei Mouravski

7 years, 2 months ago (2013-10-24 17:35:50 UTC) #2

Message was sent while issue was closed.

Here are some notes.

https://codereview.chromium.org/40703002/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_MutationObserver.darttemplate (right):

https://codereview.chromium.org/40703002/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_MutationObserver.darttemplate:23: * Observes
the target for the specified changes.
Maybe "Observes the target node for DOM changes." (Or say mutations.)

https://codereview.chromium.org/40703002/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_MutationObserver.darttemplate:24: *
"[childList], ... , and [attributeFilter] configure which mutations are
observed.
If [childList] is `true`, then mutations to [target]'s children are observed.
..."

https://codereview.chromium.org/40703002/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_MutationObserver.darttemplate:27: * * Either
childList, attributes or characterData must be true.
"At least one of [childList]... must be `true`."

https://codereview.chromium.org/40703002/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_MutationObserver.darttemplate:29: * * If
attributeFilter is specified then attributes must be true.
"...must also be `true`."

https://codereview.chromium.org/40703002/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_MutationObserver.darttemplate:30: * * If
characterDataOldValue is true then characterData must be true.
"...must also be `true`."

Expand Messages | Collapse Messages