It's a compile-time error if a const constructor call fails

It's a compile-time error if a const constructor call fails

Making it a compile-time error if a const constructor call
fails. Also improve error message when invoking dart code during
compilation fails.

Fixes issue 14302

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29212

[srdjan, 2013-10-24 17:03:32]

lgtm

https://codereview.chromium.org/40683002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (left):

https://codereview.chromium.org/40683002/diff/1/runtime/vm/parser.cc#oldcode108
runtime/vm/parser.cc:108: stack_trace ^= Object::Clone(stack_trace, Heap::kOld);
Why not Canonicalize instead of Clone?

https://codereview.chromium.org/40683002/diff/1/tests/co19/co19-co19.status
File tests/co19/co19-co19.status (right):

https://codereview.chromium.org/40683002/diff/1/tests/co19/co19-co19.status#n...
tests/co19/co19-co19.status:18:
Language/07_Classes/6_Constructors/3_Constant_Constructors_A05_t04: fail, pass,
ok # co19 issue 634
Why all of those (fail, pass, ok)? There are specific status files if needed:
co19-runtime, co19-dart2js, etc.

[hausner, 2013-10-24 17:09:31]

Thank you.

https://codereview.chromium.org/40683002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (left):

https://codereview.chromium.org/40683002/diff/1/runtime/vm/parser.cc#oldcode108
runtime/vm/parser.cc:108: stack_trace ^= Object::Clone(stack_trace, Heap::kOld);
On 2013/10/24 17:03:32, srdjan wrote:
> Why not Canonicalize instead of Clone?

This code goes away, but I don't think canonicalizing stack traces would make
sense. We don't keep them around.

https://codereview.chromium.org/40683002/diff/1/tests/co19/co19-co19.status
File tests/co19/co19-co19.status (right):

https://codereview.chromium.org/40683002/diff/1/tests/co19/co19-co19.status#n...
tests/co19/co19-co19.status:18:
Language/07_Classes/6_Constructors/3_Constant_Constructors_A05_t04: fail, pass,
ok # co19 issue 634
On 2013/10/24 17:03:32, srdjan wrote:
> Why all of those (fail, pass, ok)? There are specific status files if needed:
> co19-runtime, co19-dart2js, etc.

This file is for co19 tests that are wrong. We don't care whether they happen to
pass or fail in VM, dart2js, dart2dart etc. This is a test that I just found to
be wrong. I filed co19 bug 634 for that.

[hausner, 2013-10-24 21:42:50]

Committed patchset #1 manually as r29212 (presubmit successful).