Issue 406583002: Use futures uniformly rather than a mix of futures and CPS in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 406583002: Use futures uniformly rather than a mix of futures and CPS in tests. (Closed)

Created:
6 years, 5 months ago by scheglov

Modified:
6 years, 5 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use futures uniformly rather than a mix of futures and CPS in tests. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38397

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+151 lines, -151 lines)			Patch
M	pkg/analysis_server/test/analysis_notification_highlights_test.dart	View	50 chunks	+68 lines, -66 lines	1 comment	Download
M	pkg/analysis_server/test/analysis_notification_navigation_test.dart	View	24 chunks	+38 lines, -37 lines	0 comments	Download
M	pkg/analysis_server/test/analysis_notification_occurrences_test.dart	View	8 chunks	+9 lines, -11 lines	0 comments	Download
M	pkg/analysis_server/test/analysis_notification_outline_test.dart	View	9 chunks	+10 lines, -12 lines	0 comments	Download
M	pkg/analysis_server/test/analysis_notification_overrides_test.dart	View	16 chunks	+26 lines, -25 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/406583002/diff/1/pkg/analysis_server/test/analysis_notification_highlights_test.dart File pkg/analysis_server/test/analysis_notification_highlights_test.dart (right): https://codereview.chromium.org/406583002/diff/1/pkg/analysis_server/test/analysis_notification_highlights_test.dart#newcode41 pkg/analysis_server/test/analysis_notification_highlights_test.dart:41: fail( Not sure I agree that it's better ...

6 years, 5 months ago (2014-07-18 16:10:53 UTC) #2

scheglov

Committed patchset #1 manually as r38397 (presubmit successful).

6 years, 5 months ago (2014-07-18 16:22:33 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages