Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 40613003: Hoist generics-related functions from ClassMirror to TypeMirror. (Closed)

Created:
7 years, 2 months ago by rmacnak
Modified:
7 years, 2 months ago
Reviewers:
ahe, gbracha
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Hoist generics-related functions from ClassMirror to TypeMirror. R=ahe@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=29195

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -38 lines) Patch
M runtime/lib/mirrors_impl.dart View 1 1 chunk +6 lines, -1 line 0 comments Download
M sdk/lib/mirrors/mirrors.dart View 1 2 chunks +37 lines, -37 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmacnak
7 years, 2 months ago (2013-10-24 17:41:34 UTC) #1
gbracha
On 2013/10/24 17:41:34, Ryan Macnak wrote: So, do we have actual implementations for these hoisted ...
7 years, 2 months ago (2013-10-24 17:54:33 UTC) #2
ahe
lgtm
7 years, 2 months ago (2013-10-24 18:06:39 UTC) #3
rmacnak
On 2013/10/24 17:54:33, gbracha wrote: > On 2013/10/24 17:41:34, Ryan Macnak wrote: > > So, ...
7 years, 2 months ago (2013-10-24 18:52:20 UTC) #4
rmacnak
7 years, 2 months ago (2013-10-24 18:57:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r29195 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698