Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Issue 405483007: More fixes in the Fixes service. (Closed)

Created:
6 years, 5 months ago by scheglov
Modified:
6 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

More fixes in the Fixes service. Limitations: 1. Not all the fixes are ported and tested yet. 2. No unit tests for helpers yet - strings, util, etc. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38390

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2946 lines, -178 lines) Patch
M pkg/analysis_services/lib/correction/change.dart View 2 chunks +72 lines, -2 lines 0 comments Download
M pkg/analysis_services/lib/correction/fix.dart View 3 chunks +31 lines, -94 lines 0 comments Download
D pkg/analysis_services/lib/correction/source_range_factory.dart View 1 chunk +0 lines, -73 lines 0 comments Download
A pkg/analysis_services/lib/src/correction/fix.dart View 1 chunk +1736 lines, -0 lines 0 comments Download
A pkg/analysis_services/lib/src/correction/name_suggestion.dart View 1 chunk +220 lines, -0 lines 0 comments Download
A pkg/analysis_services/lib/src/correction/source_buffer.dart View 1 chunk +84 lines, -0 lines 0 comments Download
A + pkg/analysis_services/lib/src/correction/source_range.dart View 2 chunks +4 lines, -3 lines 0 comments Download
A pkg/analysis_services/lib/src/correction/strings.dart View 1 chunk +78 lines, -0 lines 0 comments Download
A pkg/analysis_services/lib/src/correction/util.dart View 1 chunk +282 lines, -0 lines 1 comment Download
M pkg/analysis_services/test/correction/fix_test.dart View 4 chunks +430 lines, -6 lines 0 comments Download
M pkg/analysis_testing/lib/mock_sdk.dart View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 5 months ago (2014-07-18 05:44:45 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/405483007/diff/1/pkg/analysis_services/lib/src/correction/util.dart File pkg/analysis_services/lib/src/correction/util.dart (right): https://codereview.chromium.org/405483007/diff/1/pkg/analysis_services/lib/src/correction/util.dart#newcode219 pkg/analysis_services/lib/src/correction/util.dart:219: String getTypeSource2(DartType type) { I assume we'll rename ...
6 years, 5 months ago (2014-07-18 13:21:35 UTC) #2
scheglov
6 years, 5 months ago (2014-07-18 15:34:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38390 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698