Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 405473006: Three new analysis server integration tests (Closed)

Created:
6 years, 5 months ago by Paul Berry
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Three new analysis server integration tests 1. server.setSubscriptions (invalid service) 2. analysis.getHover (normal operation) 3. analysis.getHover (no hover information available) Test 3 is disabled because it currently fails due to an analysis server bug. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38364

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -15 lines) Patch
A pkg/analysis_server/test/integration/analysis_domain_inttest.dart View 1 chunk +166 lines, -0 lines 2 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 5 chunks +99 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/integration/server_domain_inttest.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paul Berry
6 years, 5 months ago (2014-07-17 23:28:35 UTC) #1
scheglov
LGTM https://codereview.chromium.org/405473006/diff/1/pkg/analysis_server/test/integration/analysis_domain_inttest.dart File pkg/analysis_server/test/integration/analysis_domain_inttest.dart (right): https://codereview.chromium.org/405473006/diff/1/pkg/analysis_server/test/integration/analysis_domain_inttest.dart#newcode47 pkg/analysis_server/test/integration/analysis_domain_inttest.dart:47: return server.send('analysis.getHover', { Should we use constants?
6 years, 5 months ago (2014-07-18 00:03:38 UTC) #2
Paul Berry
Committed patchset #1 manually as r38364 (presubmit successful).
6 years, 5 months ago (2014-07-18 02:21:01 UTC) #3
Paul Berry
https://codereview.chromium.org/405473006/diff/1/pkg/analysis_server/test/integration/analysis_domain_inttest.dart File pkg/analysis_server/test/integration/analysis_domain_inttest.dart (right): https://codereview.chromium.org/405473006/diff/1/pkg/analysis_server/test/integration/analysis_domain_inttest.dart#newcode47 pkg/analysis_server/test/integration/analysis_domain_inttest.dart:47: return server.send('analysis.getHover', { On 2014/07/18 00:03:38, scheglov wrote: > ...
6 years, 5 months ago (2014-07-18 02:21:16 UTC) #4
Brian Wilkerson
6 years, 5 months ago (2014-07-18 03:24:05 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698