normalize url attributes on entry point elements

normalize url attributes on entry point elements

BUG= http://dartbug.com/20092
R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38356

[Siggi Cherem (dart-lang), 2014-07-17 22:31:50]

lgtm! just a minor suggestion below

https://codereview.chromium.org/404623002/diff/1/pkg/polymer/lib/src/build/im...
File pkg/polymer/lib/src/build/import_inliner.dart (right):

https://codereview.chromium.org/404623002/diff/1/pkg/polymer/lib/src/build/im...
pkg/polymer/lib/src/build/import_inliner.dart:53: }).then((urlsNormalized) {
since the normalization is synchronous, we can just assign it to a var directly,
instead of returning and chaining futures:

  var urlsNormalized = new _UrlN....visit(document);
  changed = changed || urlsNormalized;
  ...

[jakemac, 2014-07-17 22:36:40]

updated

https://codereview.chromium.org/404623002/diff/1/pkg/polymer/lib/src/build/im...
File pkg/polymer/lib/src/build/import_inliner.dart (right):

https://codereview.chromium.org/404623002/diff/1/pkg/polymer/lib/src/build/im...
pkg/polymer/lib/src/build/import_inliner.dart:53: }).then((urlsNormalized) {
On 2014/07/17 22:31:50, Siggi Cherem (dart-lang) wrote:
> since the normalization is synchronous, we can just assign it to a var
directly,
> instead of returning and chaining futures:
> 
>   var urlsNormalized = new _UrlN....visit(document);
>   changed = changed || urlsNormalized;
>   ...

Done.

[jakemac, 2014-07-17 22:38:35]

Committed patchset #2 manually as r38356 (presubmit successful).