Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 404453002: Int64 tweaks for type inference (Closed)

Created:
6 years, 5 months ago by sra1
Modified:
6 years, 4 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Int64 tweaks for type inference We can cause _l, _m and _h to be inferred by dart2js as a non-negative 31-bit int which leads to better code for shifts. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=38680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M pkg/fixnum/lib/src/int64.dart View 4 chunks +21 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sra1
6 years, 5 months ago (2014-07-18 19:41:40 UTC) #1
sra1
I looked at this in response to https://code.google.com/p/dart/issues/detail?id=17834 There is no real perf difference from ...
6 years, 5 months ago (2014-07-24 20:25:28 UTC) #2
floitsch
LGTM.
6 years, 4 months ago (2014-07-29 14:25:39 UTC) #3
sra1
6 years, 4 months ago (2014-07-29 16:51:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r38680 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698