- Fail if toolchain is not set instead of warning always even if not necessary.

- Fail if toolchain is not set instead of warning always even if not necessary.

R=whesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38460

[Ivan Posva, 2014-07-22 13:26:10]

https://codereview.chromium.org/404333004/diff/1/tools/build.py
File tools/build.py (right):

https://codereview.chromium.org/404333004/diff/1/tools/build.py#newcode537
tools/build.py:537: if BuildOneConfig(options, target, target_os, mode, arch,
cross_build) != 0:
long line fixed

[Bill Hesse, 2014-07-22 14:21:07]

lgtm

https://codereview.chromium.org/404333004/diff/1/tools/build.py
File tools/build.py (left):

https://codereview.chromium.org/404333004/diff/1/tools/build.py#oldcode370
tools/build.py:370: filter_xcodebuild_output = False
Should override_tools be renamed to cross_compilation?

[Ivan Posva, 2014-07-22 14:26:13]

https://codereview.chromium.org/404333004/diff/1/tools/build.py
File tools/build.py (left):

https://codereview.chromium.org/404333004/diff/1/tools/build.py#oldcode370
tools/build.py:370: filter_xcodebuild_output = False
On 2014/07/22 14:21:07, Bill Hesse wrote:
> Should override_tools be renamed to cross_compilation?

As I think more about this, it seems to be a problem that tool chain override
and cross-compilation are being stuffed into one flag. You might want to use a
different toolchain even though you are not cross-building. For example while
testing different versions of gcc or switching between clang and gcc.

I think this is something that got lost along the way of refactoring this code.

[Ivan Posva, 2014-07-22 15:01:10]

Committed patchset #1 manually as r38460 (presubmit successful).

[zra, 2014-07-22 16:33:56]

On 2014/07/22 14:26:13, Ivan Posva wrote:
> For example while
> testing different versions of gcc or switching between clang and gcc.
> 
> I think this is something that got lost along the way of refactoring this
code.

This is still possible, unless I'm missing something. The default host toolchain
is only forced (override_tools=False passed to BuildOneConfig) when doing a
cross-build for create_sdk. Otherwise, a toolchain specified by --toolchain is
used whether or not it's a cross-build. Maybe the parameter should be called
'allow_toolchain_override'?