Issue 40323002: Remove dart:json

Issue 40323002: Remove dart:json (Closed)

Created:
7 years, 2 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 1 month ago

Reviewers:
Florian Schneider, floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove dart:json BUG= http://dartbug.com/12843 R=floitsch@google.com, fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=29240

Patch Set 2 : Bad merge in convert/json.dart, a few other bugs. Updated co19 expectations. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+441 lines, -1108 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine.services_test/src/com/google/dart/engine/services/completion/CompletionLibraryTests.java	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine.services_test/src/com/google/dart/engine/services/completion/CompletionTests.java	View		2 chunks	+19 lines, -17 lines	0 comments	Download
M	pkg/yaml/README.md	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/benchmark_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/bootstrap.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/object.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/object_store.h	View		4 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/object_store.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/symbols.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/vm.gypi	View		4 chunks	+0 lines, -36 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/dartdoc.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/convert_patch.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/libraries.dart	View		4 chunks	+7 lines, -11 lines	0 comments	Download
M	sdk/lib/convert/convert.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/convert/json.dart	View	1	9 chunks	+198 lines, -13 lines	0 comments	Download
D	sdk/lib/json/json.dart	View		1 chunk	+0 lines, -813 lines	0 comments	Download
D	sdk/lib/json/json_sources.gypi	View		1 chunk	+0 lines, -11 lines	0 comments	Download
M	tests/co19/co19-co19.status	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
M	tests/corelib/json_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/corelib/string_source_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/html/isolates_test.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/lib/json/json_test.dart	View	1	6 chunks	+59 lines, -59 lines	0 comments	Download
M	tests/standalone/io/stdin_sync_script.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	tests/standalone/io/stdin_sync_test.dart	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/utils/json_test.dart	View	1	3 chunks	+104 lines, -104 lines	0 comments	Download
M	tools/testing/dart/record_and_replay.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM except for the removal of the encoder function. https://codereview.chromium.org/40323002/diff/1/sdk/lib/convert/json.dart File sdk/lib/convert/json.dart (left): https://codereview.chromium.org/40323002/diff/1/sdk/lib/convert/json.dart#oldcode104 sdk/lib/convert/json.dart:104: ...

7 years, 2 months ago (2013-10-24 16:06:35 UTC) #2

Lasse Reichstein Nielsen

Fixed the bad merge. Updated test expectations. https://codereview.chromium.org/40323002/diff/1/sdk/lib/convert/json.dart File sdk/lib/convert/json.dart (left): https://codereview.chromium.org/40323002/diff/1/sdk/lib/convert/json.dart#oldcode104 sdk/lib/convert/json.dart:104: Object encode(Object ...

7 years, 1 month ago (2013-10-25 08:18:02 UTC) #3

Lasse Reichstein Nielsen

7 years, 1 month ago (2013-10-25 10:34:06 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r29240 (presubmit successful).

Expand Messages | Collapse Messages