Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 402843003: Deprecate the source_maps span classes. (Closed)

Created:
6 years, 5 months ago by nweiz
Modified:
6 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Deprecate the source_maps span classes. This also updates source_maps to take the new classes where possible. BUG=19930 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=38524

Patch Set 1 #

Total comments: 8

Patch Set 2 : code review #

Patch Set 3 : add -dev to version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -24 lines) Patch
M pkg/source_maps/CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/source_maps/lib/builder.dart View 1 4 chunks +31 lines, -6 lines 0 comments Download
M pkg/source_maps/lib/parser.dart View 5 chunks +19 lines, -7 lines 0 comments Download
M pkg/source_maps/lib/printer.dart View 4 chunks +21 lines, -9 lines 0 comments Download
M pkg/source_maps/lib/refactor.dart View 2 chunks +8 lines, -1 line 0 comments Download
M pkg/source_maps/lib/span.dart View 1 10 chunks +10 lines, -0 lines 0 comments Download
A pkg/source_maps/lib/src/span_wrapper.dart View 1 chunk +85 lines, -0 lines 0 comments Download
M pkg/source_maps/pubspec.yaml View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
6 years, 5 months ago (2014-07-18 01:17:13 UTC) #1
Siggi Cherem (dart-lang)
LGTM Just minor comments below. https://codereview.chromium.org/402843003/diff/1/pkg/source_maps/CHANGELOG.md File pkg/source_maps/CHANGELOG.md (right): https://codereview.chromium.org/402843003/diff/1/pkg/source_maps/CHANGELOG.md#newcode1 pkg/source_maps/CHANGELOG.md:1: ## 0.9.3 let's move ...
6 years, 5 months ago (2014-07-18 01:40:54 UTC) #2
nweiz
code review
6 years, 5 months ago (2014-07-23 23:15:42 UTC) #3
nweiz
add -dev to version
6 years, 5 months ago (2014-07-23 23:17:13 UTC) #4
nweiz
https://codereview.chromium.org/402843003/diff/1/pkg/source_maps/CHANGELOG.md File pkg/source_maps/CHANGELOG.md (right): https://codereview.chromium.org/402843003/diff/1/pkg/source_maps/CHANGELOG.md#newcode1 pkg/source_maps/CHANGELOG.md:1: ## 0.9.3 On 2014/07/18 01:40:53, Siggi Cherem (dart-lang) wrote: ...
6 years, 5 months ago (2014-07-23 23:17:18 UTC) #5
nweiz
6 years, 5 months ago (2014-07-23 23:17:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r38524 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698