Issue 402433003: Search only for potential name references to Class members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 402433003: Search only for potential name references to Class members. (Closed)

Created:
6 years, 5 months ago by scheglov

Modified:
6 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Search only for potential name references to Class members. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38309

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -4 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/search/ui/FindReferencesAction_NEW.java	View	3 chunks	+4 lines, -2 lines	1 comment	Download
M	pkg/analysis_server/lib/src/search/element_references.dart	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/search/element_references_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/402433003/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/search/ui/FindReferencesAction_NEW.java File editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/search/ui/FindReferencesAction_NEW.java (right): https://codereview.chromium.org/402433003/diff/1/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/search/ui/FindReferencesAction_NEW.java#newcode189 editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/search/ui/FindReferencesAction_NEW.java:189: // long start = System.nanoTime(); Remove debugging code?

6 years, 5 months ago (2014-07-16 20:21:58 UTC) #2

scheglov

6 years, 5 months ago (2014-07-16 20:40:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r38309 (presubmit successful).

Expand Messages | Collapse Messages