Issue 401753002: Move a number of packages and some of pub over to using source_span.

Issue 401753002: Move a number of packages and some of pub over to using source_span. (Closed)

Created:
6 years, 5 months ago by nweiz

Modified:
6 years, 5 months ago

Reviewers:
Bob Nystrom, Siggi Cherem (dart-lang), Emily Fortuna

CC:
reviews_dartlang.org, Siggi Cherem (dart-lang), Emily Fortuna

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Move a number of packages and some of pub over to using source_span. R=efortuna@google.com, rnystrom@google.com, sigmund@google.com BUG=19930 Committed: https://code.google.com/p/dart/source/detail?r=38526

Patch Set 2 : Code review changes #

Patch Set 3 : Code review changes #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+184 lines, -177 lines)			Patch
M	pkg/docgen/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/http_parser/CHANGELOG.md	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/http_parser/pubspec.yaml	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/polymer/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/string_scanner/CHANGELOG.md	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	pkg/string_scanner/lib/src/exception.dart	View		1 chunk	+6 lines, -7 lines	0 comments	Download
M	pkg/string_scanner/lib/src/span_scanner.dart	View	1 2	5 chunks	+16 lines, -16 lines	0 comments	Download
M	pkg/string_scanner/lib/src/string_scanner.dart	View		3 chunks	+4 lines, -5 lines	0 comments	Download
M	pkg/string_scanner/pubspec.yaml	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/string_scanner/test/span_scanner_test.dart	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/yaml/CHANGELOG.md	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	pkg/yaml/lib/src/model.dart	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/yaml/lib/src/null_span.dart	View		1 chunk	+6 lines, -32 lines	0 comments	Download
M	pkg/yaml/lib/src/parser.dart	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/yaml/lib/src/yaml_exception.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/yaml/lib/src/yaml_node.dart	View		7 chunks	+41 lines, -31 lines	0 comments	Download
M	pkg/yaml/lib/src/yaml_node_wrapper.dart	View		8 chunks	+12 lines, -12 lines	0 comments	Download
M	pkg/yaml/lib/yaml.dart	View		2 chunks	+10 lines, -10 lines	0 comments	Download
M	pkg/yaml/pubspec.yaml	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/yaml/test/yaml_node_wrapper_test.dart	View		5 chunks	+11 lines, -11 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/transformer_config.dart	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/transformer_id.dart	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/transformer_isolate.dart	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/pubspec.dart	View		7 chunks	+10 lines, -11 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! https://codereview.chromium.org/401753002/diff/1/pkg/string_scanner/lib/src/span_scanner.dart File pkg/string_scanner/lib/src/span_scanner.dart (right): https://codereview.chromium.org/401753002/diff/1/pkg/string_scanner/lib/src/span_scanner.dart#newcode56 pkg/string_scanner/lib/src/span_scanner.dart:56: /// Creates a [SourceSpan] representing the source range ...

6 years, 5 months ago (2014-07-21 19:46:25 UTC) #2

nweiz

Forgot to CC Siggi and Emily for polymer and docgen pubspec changes. https://codereview.chromium.org/401753002/diff/1/pkg/string_scanner/lib/src/span_scanner.dart File pkg/string_scanner/lib/src/span_scanner.dart ...

6 years, 5 months ago (2014-07-23 23:37:30 UTC) #5

nweiz

6 years, 5 months ago (2014-07-23 23:44:19 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 manually as r38526 (presubmit successful).

Expand Messages | Collapse Messages