Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 401683003: Specialize mint shift code on arm for a constant shift amount. (Closed)

Created:
6 years, 5 months ago by regis
Modified:
6 years, 5 months ago
Reviewers:
zra, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Specialize mint shift code on arm for a constant shift amount. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=38355

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -54 lines) Patch
runtime/vm/intermediate_language_arm.cc View 1 2 chunks +103 lines, -47 lines 0 comments Download
runtime/vm/intermediate_language_ia32.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M runtime/vm/locations.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/locations.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
regis
6 years, 5 months ago (2014-07-17 21:37:49 UTC) #1
zra
lgtm
6 years, 5 months ago (2014-07-17 22:17:09 UTC) #2
regis
On 2014/07/17 22:17:09, zra wrote: > lgtm Thanks! I just made one more change, because ...
6 years, 5 months ago (2014-07-17 22:19:32 UTC) #3
regis
6 years, 5 months ago (2014-07-17 22:29:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r38355 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698