Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 401003004: Make links to libraries from the main page work (Closed)

Created:
6 years, 5 months ago by Alan Knight
Modified:
6 years, 5 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make links to libraries from the main page work BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=38439

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use ./ instead of hard-coding the full URL #

Total comments: 2

Patch Set 3 : Add a TODO for resolving names from the README better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M pkg/docgen/lib/src/generator.dart View 1 2 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alan Knight
6 years, 5 months ago (2014-07-18 19:42:03 UTC) #1
Emily Fortuna
https://codereview.chromium.org/401003004/diff/1/pkg/docgen/lib/src/generator.dart File pkg/docgen/lib/src/generator.dart (right): https://codereview.chromium.org/401003004/diff/1/pkg/docgen/lib/src/generator.dart#newcode432 pkg/docgen/lib/src/generator.dart:432: * [dart:core](https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart:core): are you sure you want to hard-code ...
6 years, 5 months ago (2014-07-18 19:44:53 UTC) #2
Alan Knight
Unfortunately, I've got nothing better than putting "./" in front of it. I think that ...
6 years, 5 months ago (2014-07-21 17:04:06 UTC) #3
Emily Fortuna
https://codereview.chromium.org/401003004/diff/20001/pkg/docgen/lib/src/generator.dart File pkg/docgen/lib/src/generator.dart (right): https://codereview.chromium.org/401003004/diff/20001/pkg/docgen/lib/src/generator.dart#newcode426 pkg/docgen/lib/src/generator.dart:426: const _DEFAULT_SDK_INTRODUCTION = If this is what we're going ...
6 years, 5 months ago (2014-07-21 17:21:55 UTC) #4
Alan Knight
https://codereview.chromium.org/401003004/diff/20001/pkg/docgen/lib/src/generator.dart File pkg/docgen/lib/src/generator.dart (right): https://codereview.chromium.org/401003004/diff/20001/pkg/docgen/lib/src/generator.dart#newcode426 pkg/docgen/lib/src/generator.dart:426: const _DEFAULT_SDK_INTRODUCTION = On 2014/07/21 17:21:54, Emily Fortuna wrote: ...
6 years, 5 months ago (2014-07-21 17:28:26 UTC) #5
Emily Fortuna
lgtm
6 years, 5 months ago (2014-07-21 17:28:53 UTC) #6
Alan Knight
6 years, 5 months ago (2014-07-21 17:31:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r38439 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698