Issue 400493002: Hide dangerous interface String::Equals/Hash(uint8_t*,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 400493002: Hide dangerous interface String::Equals/Hash(uint8_t*,... (Closed)

Created:
6 years, 5 months ago by koda

Modified:
6 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Hide dangerous interface String::Equals/Hash(uint8_t*,... The method String::Equals(uint8_t*, intptr_t) was incorrectly specified as operating on UTF-8, when it was actually assuming Latin-1. Still, friends that use templates (like Symbols) can still access the convenient overloaded Equals/Hash. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=38343

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	runtime/vm/object.h	View		3 chunks	+11 lines, -3 lines	0 comments	Download
	M	runtime/vm/object_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

koda

6 years, 5 months ago (2014-07-17 20:07:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r38343 (presubmit successful).

Expand Messages | Collapse Messages