Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 399763002: Use ":" to separate package and executable name in pub global run. (Closed)

Created:
6 years, 5 months ago by Bob Nystrom
Modified:
6 years, 5 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use ":" to separate package and executable name in pub global run. BUG=https://code.google.com/p/dart/issues/detail?id=19863 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=38354

Patch Set 1 #

Total comments: 1

Messages

Total messages: 3 (0 generated)
Bob Nystrom
6 years, 5 months ago (2014-07-16 21:59:11 UTC) #1
nweiz
lgtm https://codereview.chromium.org/399763002/diff/1/sdk/lib/_internal/pub/lib/src/command/global_run.dart File sdk/lib/_internal/pub/lib/src/command/global_run.dart (right): https://codereview.chromium.org/399763002/diff/1/sdk/lib/_internal/pub/lib/src/command/global_run.dart#newcode37 sdk/lib/_internal/pub/lib/src/command/global_run.dart:37: // TODO(rnystrom): Allow "foo" as a synonym for ...
6 years, 5 months ago (2014-07-17 07:15:11 UTC) #2
Bob Nystrom
6 years, 5 months ago (2014-07-17 22:24:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r38354 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698