Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 39943002: Make FileSystemEntity.watch return a broadcast stream. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make FileSystemEntity.watch return a broadcast stream. BUG=https://code.google.com/p/dart/issues/detail?id=14378 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29170

Patch Set 1 #

Patch Set 2 : Document broadcast stream. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M runtime/bin/file_patch.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/io/file_system_entity.dart View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 1 month ago (2013-10-24 11:06:11 UTC) #1
Søren Gjesse
lgtm with commnets Document that this is a broadcast stream.
7 years, 1 month ago (2013-10-24 12:24:41 UTC) #2
Anders Johnsen
7 years, 1 month ago (2013-10-24 12:30:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29170 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698