Issue 399133004: Revert using relative paths because of the problems with the Pub bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 399133004: Revert using relative paths because of the problems with the Pub bots. (Closed)

Created:
6 years, 5 months ago by scheglov

Modified:
6 years, 5 months ago

Reviewers:
nweiz, Paul Berry, Brian Wilkerson, danrubel, Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert using relative paths because of the problems with the Pub bots. R=brianwilkerson@google.com, nweiz@google.com, paulberry@google.com, danrubel@google.com, rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=38345

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -15 lines)			Patch
M	pkg/analysis_server/pubspec.yaml	View	1 chunk	+4 lines, -7 lines	1 comment	Download
M	pkg/analysis_services/pubspec.yaml	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	pkg/analysis_testing/pubspec.yaml	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

lgtm https://codereview.chromium.org/399133004/diff/1/pkg/analysis_server/pubspec.yaml File pkg/analysis_server/pubspec.yaml (right): https://codereview.chromium.org/399133004/diff/1/pkg/analysis_server/pubspec.yaml#newcode2 pkg/analysis_server/pubspec.yaml:2: version: 0.1.0 Out of curiousity, why do we ...

6 years, 5 months ago (2014-07-17 18:47:15 UTC) #3

scheglov

6 years, 5 months ago (2014-07-17 20:42:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r38345 (presubmit successful).

Expand Messages | Collapse Messages