Start writing integration tests for the analysis server.

Start writing integration tests for the analysis server.

R=brianwilkerson@google.com, jwren@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38288

[Paul Berry, 2014-07-16 05:04:57]

Why four reviewers?  Since we're probably going to have a lot of tests that use
this infrastructure, so I want to make sure it's pretty well reviewed before I
put too much effort into writing them.

A few things worth noting:

- I've only written one test so far.  It's in analysis_error_inttest.dart and is
pretty simple.  Most of the work here is in the infrastructure (in
integration_tests.dart).

- I made a generic Matcher class (MatchesJsonObject) which can be used to
describe the kind of JSON structures we're using in the analysis server API. 
The idea is that each JSON structure in the API will have a corresponding
matcher in integration_tests.dart, so the tests themselves can validate the JSON
data using a single expect call like "expect(x, isLocation);" rather than a long
sequence of expect() calls to validate each part of the JSON structure one at a
time.

- If a test ever fails (or hangs), you can get it to print out all of the
messages it exchanges with the server by calling debugStdio() from within the
test.  You can call this at any time in the test; if some messages have already
been exchanged with the server, it will print them out immediately so that
you'll always see a complete picture of the conversation.

- The set of messages exchanged with the server is also recorded in
Server._recordedStdio, so if you're running a test in the debugger you can
always look there even if debugStdio() hasn't been called.

[Brian Wilkerson, 2014-07-16 14:08:51]

I'm sure it will evolve over time, but LGTM

https://codereview.chromium.org/398693002/diff/1/pkg/analysis_server/test/int...
File pkg/analysis_server/test/integration/analysis_error_inttest.dart (right):

https://codereview.chromium.org/398693002/diff/1/pkg/analysis_server/test/int...
pkg/analysis_server/test/integration/analysis_error_inttest.dart:28:
expect(errors[0]['location']['file'], equals(filePath));
Consider adding specialized matcher builders, such as

  expect(errors[0], isAnalysisErrorWith(location: isLocationWith(file:
equals(filePath))));

that would safely check the values of specific fields.

Otherwise, this might want to be re-written to check that 'location' is not null
and produce a specialized failure message if it is.

[jwren, 2014-07-16 14:41:00]

LGTM

[scheglov, 2014-07-16 15:27:06]

LGTM

[Paul Berry, 2014-07-16 16:00:00]

https://codereview.chromium.org/398693002/diff/1/pkg/analysis_server/test/int...
File pkg/analysis_server/test/integration/analysis_error_inttest.dart (right):

https://codereview.chromium.org/398693002/diff/1/pkg/analysis_server/test/int...
pkg/analysis_server/test/integration/analysis_error_inttest.dart:28:
expect(errors[0]['location']['file'], equals(filePath));
On 2014/07/16 14:08:51, Brian Wilkerson wrote:
> Consider adding specialized matcher builders, such as
> 
>   expect(errors[0], isAnalysisErrorWith(location: isLocationWith(file:
> equals(filePath))));
> 
> that would safely check the values of specific fields.
> 
> Otherwise, this might want to be re-written to check that 'location' is not
null
> and produce a specialized failure message if it is.

Good idea.  I will do this in a future CL.

[Paul Berry, 2014-07-16 16:02:27]

Committed patchset #1 manually as r38288 (presubmit successful).