Issue 39783003: Substitute types in instances of generic classes.

Issue 39783003: Substitute types in instances of generic classes. (Closed)

Created:
7 years, 2 months ago by zarah

Modified:
7 years, 1 month ago

Reviewers:
Johnni Winther, ahe

CC:
reviews_dartlang.org, vm-dev_dartlang.org, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Substitute types in instances of generic classes. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=29235

Patch Set 2 : Addressed comments. #

Patch Set 3 : Added regression test and updated dart2js_extra.status. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+243 lines, -79 lines)			Patch
M	sdk/lib/_internal/lib/js_mirrors.dart	View	1 2	14 chunks	+149 lines, -66 lines	0 comments	Download
M	tests/compiler/dart2js_extra/dart2js_extra.status	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/lib/mirrors/class_mirror_type_variables_test.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
A	tests/lib/mirrors/generic_type_mirror_test.dart	View	1	1 chunk	+78 lines, -0 lines	0 comments	Download
A +	tests/lib/mirrors/regress_14304_test.dart	View	1 2	1 chunk	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/39783003/diff/70001/tests/lib/mirrors/generic_type_mirror_test.dart File tests/lib/mirrors/generic_type_mirror_test.dart (right): https://codereview.chromium.org/39783003/diff/70001/tests/lib/mirrors/generic_type_mirror_test.dart#newcode41 tests/lib/mirrors/generic_type_mirror_test.dart:41: Expect.equals(reflect(new Baz()).type, field.type); /// 01: ok Store 'reflect(new ...

7 years, 2 months ago (2013-10-24 13:43:10 UTC) #2

zarah

https://codereview.chromium.org/39783003/diff/70001/tests/lib/mirrors/generic_type_mirror_test.dart File tests/lib/mirrors/generic_type_mirror_test.dart (right): https://codereview.chromium.org/39783003/diff/70001/tests/lib/mirrors/generic_type_mirror_test.dart#newcode41 tests/lib/mirrors/generic_type_mirror_test.dart:41: Expect.equals(reflect(new Baz()).type, field.type); /// 01: ok On 2013/10/24 13:43:11, ...

7 years, 1 month ago (2013-10-25 06:36:14 UTC) #3

zarah

7 years, 1 month ago (2013-10-25 07:53:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r29235 (presubmit successful).

Expand Messages | Collapse Messages