Issue 397823004: Detect invalid const constructor due to non-const initializer in field declaration.

Issue 397823004: Detect invalid const constructor due to non-const initializer in field declaration. (Closed)

Created:
6 years, 5 months ago by Paul Berry

Modified:
6 years, 5 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Detect invalid const constructor due to non-const initializer in field declaration. BUG=dartbug.com/18780 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=38432

Patch Set 2 : Comment fix #

Total comments: 4

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -32 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View		1 chunk	+9 lines, -0 lines	2 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ConstantVerifier.java	View		5 chunks	+62 lines, -26 lines	2 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View		1 chunk	+28 lines, -0 lines	0 comments	Download
M	pkg/pkg.status	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A +	tests/language/const_constructor_nonconst_field_test.dart	View		1 chunk	+8 lines, -6 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM https://codereview.chromium.org/397823004/diff/20001/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java (right): https://codereview.chromium.org/397823004/diff/20001/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java#newcode177 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java:177: CONST_CONSTRUCTOR_WITH_FIELD_INITIALIZED_BY_NON_CONST( I think this constant should be moved ...

6 years, 5 months ago (2014-07-20 18:55:16 UTC) #2

Paul Berry

https://codereview.chromium.org/397823004/diff/20001/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java (right): https://codereview.chromium.org/397823004/diff/20001/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java#newcode177 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java:177: CONST_CONSTRUCTOR_WITH_FIELD_INITIALIZED_BY_NON_CONST( On 2014/07/20 18:55:16, scheglov wrote: > I think ...

6 years, 5 months ago (2014-07-21 15:52:14 UTC) #3

Paul Berry

6 years, 5 months ago (2014-07-21 15:52:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r38432 (presubmit successful).

Expand Messages | Collapse Messages