Create a separate packages directory for running pub.

Create a separate packages directory for running pub.

Once issue 6943 is fixed, the http package will start using pub's
cross-platform library support to work with both dart:io and
dart:html. However, this package is also used *within* pub, so we need
a way for pub to import it that doesn't require it being run through
pub.

This change supports this by stripping out and dart:html imports from
the http package and creating a special packages directory only used
by pub that uses this modified version.

BUG=20068
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38255

[floitsch, 2014-07-15 20:15:59]

LGTM.

https://codereview.chromium.org/397773002/diff/1/tools/remove_html_imports.py
File tools/remove_html_imports.py (right):

https://codereview.chromium.org/397773002/diff/1/tools/remove_html_imports.py...
tools/remove_html_imports.py:19: HTML_IMPORT = re.compile(r'import ["' "'"
r']dart:(html|html_common|indexed_db'
use long-strings. (''') this way the ['"] gets easier.

[nweiz, 2014-07-15 20:27:49]

https://codereview.chromium.org/397773002/diff/1/tools/remove_html_imports.py
File tools/remove_html_imports.py (right):

https://codereview.chromium.org/397773002/diff/1/tools/remove_html_imports.py...
tools/remove_html_imports.py:19: HTML_IMPORT = re.compile(r'import ["' "'"
r']dart:(html|html_common|indexed_db'
On 2014/07/15 20:15:58, floitsch wrote:
> use long-strings. (''') this way the ['"] gets easier.

Done.

[nweiz, 2014-07-15 20:28:14]

Committed patchset #2 manually as r38255 (presubmit successful).

[ahe, 2014-08-06 14:19:57]

https://codereview.chromium.org/397773002/diff/20001/pkg/pkg.gyp
File pkg/pkg.gyp (right):

https://codereview.chromium.org/397773002/diff/20001/pkg/pkg.gyp#newcode71
pkg/pkg.gyp:71: '../site/try',
Why is this depending on Try Dart?

[nweiz, 2014-08-06 19:32:10]

https://codereview.chromium.org/397773002/diff/20001/pkg/pkg.gyp
File pkg/pkg.gyp (right):

https://codereview.chromium.org/397773002/diff/20001/pkg/pkg.gyp#newcode71
pkg/pkg.gyp:71: '../site/try',
On 2014/08/06 14:19:57, ahe wrote:
> Why is this depending on Try Dart?

Other than the http stuff, it's a straight copy of the "packages" target. I
don't know why that depends on Try Dart, but if it needs to then this does too.

[ricow1, 2014-08-07 07:56:40]

https://codereview.chromium.org/397773002/diff/20001/pkg/pkg.gyp
File pkg/pkg.gyp (right):

https://codereview.chromium.org/397773002/diff/20001/pkg/pkg.gyp#newcode71
pkg/pkg.gyp:71: '../site/try',
On 2014/08/06 19:32:10, nweiz wrote:
> On 2014/08/06 14:19:57, ahe wrote:
> > Why is this depending on Try Dart?
> 
> Other than the http stuff, it's a straight copy of the "packages" target. I
> don't know why that depends on Try Dart, but if it needs to then this does
too.
site/try is an input in pkg_packages to get a symlink in the output
folder/packages, i.e., it will be in the packageroot and people can use it. I
don't think 
you need that for pub packages - unless you rely on package:try.

[nweiz, 2014-08-11 18:51:30]

On 2014/08/07 07:56:40, ricow1 wrote:
> https://codereview.chromium.org/397773002/diff/20001/pkg/pkg.gyp
> File pkg/pkg.gyp (right):
> 
> https://codereview.chromium.org/397773002/diff/20001/pkg/pkg.gyp#newcode71
> pkg/pkg.gyp:71: '../site/try',
> On 2014/08/06 19:32:10, nweiz wrote:
> > On 2014/08/06 14:19:57, ahe wrote:
> > > Why is this depending on Try Dart?
> > 
> > Other than the http stuff, it's a straight copy of the "packages" target. I
> > don't know why that depends on Try Dart, but if it needs to then this does
> too.
> site/try is an input in pkg_packages to get a symlink in the output
> folder/packages, i.e., it will be in the packageroot and people can use it. I
> don't think 
> you need that for pub packages - unless you rely on package:try.

We don't, but I'd like to avoid making this build rule diverge from the normal
"packages" build rule as much as possible. If someone changes the "packages"
rule, I want it to be very clear that they should also modify "pkg_packages" in
exactly the same way.

[ricow1, 2014-08-12 05:57:21]

https://codereview.chromium.org/397773002/diff/20001/utils/pub/pub.gyp
File utils/pub/pub.gyp (right):

https://codereview.chromium.org/397773002/diff/20001/utils/pub/pub.gyp#newcode24
utils/pub/pub.gyp:24: '<(SHARED_INTERMEDIATE_DIR)/dart2js_files.stamp',
Does pub need pub_packages target to be build before pub is build?
If so, you need to have this in the inputs as well:
'<(SHARED_INTERMEDIATE_DIR)/pub_packages.stamp'

Generally speaking, a dependency does not imply any particular build order
(because in a normal c world you don't have that, you do the linking at the end)

[nweiz, 2014-08-12 23:12:18]

https://codereview.chromium.org/397773002/diff/20001/utils/pub/pub.gyp
File utils/pub/pub.gyp (right):

https://codereview.chromium.org/397773002/diff/20001/utils/pub/pub.gyp#newcode24
utils/pub/pub.gyp:24: '<(SHARED_INTERMEDIATE_DIR)/dart2js_files.stamp',
On 2014/08/12 05:57:21, ricow1 wrote:
> Does pub need pub_packages target to be build before pub is build?
> If so, you need to have this in the inputs as well:
> '<(SHARED_INTERMEDIATE_DIR)/pub_packages.stamp'
> 
> Generally speaking, a dependency does not imply any particular build order
> (because in a normal c world you don't have that, you do the linking at the
end)

Done.