Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 397243002: Make IterableMixinWorkaround using classes return correctly typed Iterables. (Closed)

Created:
6 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make IterableMixinWorkaround using classes return correctly typed Iterables. BUG= http://dartbug.com/13646 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=38372

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment, #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -79 lines) Patch
M runtime/lib/array.dart View 10 chunks +18 lines, -16 lines 0 comments Download
M runtime/lib/growable_array.dart View 6 chunks +10 lines, -9 lines 0 comments Download
M runtime/lib/typed_data.dart View 6 chunks +25 lines, -23 lines 0 comments Download
M sdk/lib/_internal/lib/js_array.dart View 5 chunks +9 lines, -8 lines 0 comments Download
M sdk/lib/collection/list.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/internal/iterable.dart View 1 7 chunks +26 lines, -22 lines 0 comments Download
M sdk/lib/internal/list.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 2 chunks +5 lines, -0 lines 0 comments Download
A tests/corelib/iterable_return_type_test.dart View 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein Nielsen
6 years, 5 months ago (2014-07-17 10:16:36 UTC) #1
floitsch
LGTM after verification that this doesn't introduce big performance and/or size regressions. https://codereview.chromium.org/397243002/diff/1/sdk/lib/internal/iterable.dart File sdk/lib/internal/iterable.dart ...
6 years, 5 months ago (2014-07-17 11:39:21 UTC) #2
floitsch
Also, I think this warrants a "Be careful" mail to the mailing-list. This bug-fix could ...
6 years, 5 months ago (2014-07-17 11:39:55 UTC) #3
Lasse Reichstein Nielsen
Performance looks fine. I'll write a mail, but since it was only broken on the ...
6 years, 5 months ago (2014-07-18 07:47:42 UTC) #4
Lasse Reichstein Nielsen
6 years, 5 months ago (2014-07-18 08:08:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r38372 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698