Profiler cleanup

Profiler cleanup

BUG=
R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38409

[siva, 2014-07-18 19:38:28]

lgtm

https://chromiumcodereview.appspot.com/397163002/diff/1/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://chromiumcodereview.appspot.com/397163002/diff/1/runtime/vm/profiler.c...
runtime/vm/profiler.cc:1670: ASSERT(sp <= fp);
is the assert necessary because the code below would do nothing as should
_read_pc_marker will become false and the code below would do nothing.

Maybe the code can be structured as:
if (fp > sp) {
#if defined(TARGET_OS_WINDOWS)
  const intptr_t kPageMask....
  if ((original_fp_ & kPageMask) == 0) return;
#endif
  const uword pc_marker ....
  sample->set_pc_marker(pc_marker);
}

[Cutch, 2014-07-18 20:55:15]

https://chromiumcodereview.appspot.com/397163002/diff/1/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://chromiumcodereview.appspot.com/397163002/diff/1/runtime/vm/profiler.c...
runtime/vm/profiler.cc:1670: ASSERT(sp <= fp);
On 2014/07/18 19:38:27, siva wrote:
> is the assert necessary because the code below would do nothing as should
> _read_pc_marker will become false and the code below would do nothing.
> 
> Maybe the code can be structured as:
> if (fp > sp) {
> #if defined(TARGET_OS_WINDOWS)
>   const intptr_t kPageMask....
>   if ((original_fp_ & kPageMask) == 0) return;
> #endif
>   const uword pc_marker ....
>   sample->set_pc_marker(pc_marker);
> }

Done.

[Cutch, 2014-07-18 20:55:31]

Committed patchset #2 manually as r38409 (presubmit successful).