Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 397073003: Update status of html tests passing on chrome 36 correctly. (Closed)

Created:
6 years, 5 months ago by Bill Hesse
Modified:
6 years, 5 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, Emily Fortuna
Visibility:
Public.

Description

Update status of html tests passing on chrome 36 correctly. Revision 38323 incorrectly marked one of the tests as passing on Safari. Updating Windows bots to Chrome 36 makes them pass on Windows as well. BUG=dartbug.com/18931 R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=38328

Patch Set 1 #

Patch Set 2 : Remove old skip of test on ie10. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M tests/html/html.status View 1 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
The tests now pass on Windows, Linux, and Mac OS X, so on all platforms ...
6 years, 5 months ago (2014-07-17 12:36:29 UTC) #1
kustermann
lgtm
6 years, 5 months ago (2014-07-17 13:10:01 UTC) #2
Bill Hesse
6 years, 5 months ago (2014-07-17 13:36:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r38328 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698